-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify SocialConnect ready for Alfajores L2 Migration #280
Comments
Can you please take a look at the tasks? My understanding is that there's nothing to do for Alfajores L2. There's only 2 things i imagine make sense:
What i see is too many tasks that makes it unclear what this really is. Am i mistaken? Also if there are thing that needs to be post-deployment, let's create another isseu for that |
I agree with @mcortesi , I didn't write most of the original tasks and am not sure I understand all of them (update: I removed these tickets from the epic). ODIS depends on Forno, so this is really just a task to make sure Forno transitions to the L2 full node cleanly at migration time.
Nothing changes for ODIS as a result of the L2 migration except for the full node it talks to If 'https://forno.celo.org/' is redirected to an L2 full node, and signers all rely on forno (which we can verify, added a ticket for this) then SocialConnect should work with Cel2 automatically Of course, we'll want to test that ODIS and the SocialConnect contracts work on Dango and make sure MiniPay tests their setup e2e on a testnet as well. I added tickets for this. |
@lvpeschke I've removed all the extraneuous tasks from this epic. I'm not sure about the contractkit one. @soloseng can you add context there? |
Hey all, could the tests on Dango happen ASAP to uncover any potential issues ASAP and decide how to tackle them, if any? |
@lvpeschke for the tests to happen we need to point Alfajores ODIS to Dango (I can ask devops for this) and then just run our existing e2e tests against that instance. This will cover There are some other tickets here that I don't understand |
@martinvol do you have more context about the above? |
adding discussion thread regarding this issue https://clabsco.slack.com/archives/CP5V8KF51/p1726158289642649 |
SocialConnect should keep working almost transparently.
Tasks
The text was updated successfully, but these errors were encountered: