Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify SocialConnect ready for Alfajores L2 Migration #280

Closed
7 tasks done
alecps opened this issue May 8, 2024 · 8 comments
Closed
7 tasks done

Verify SocialConnect ready for Alfajores L2 Migration #280

alecps opened this issue May 8, 2024 · 8 comments

Comments

@alecps
Copy link
Collaborator

alecps commented May 8, 2024

SocialConnect should keep working almost transparently.

Tasks

Preview Give feedback
  1. alecps
@mcortesi
Copy link
Contributor

@alecps @soloseng

Can you please take a look at the tasks?

My understanding is that there's nothing to do for Alfajores L2. There's only 2 things i imagine make sense:

  • Do a quick test of using ODIS pointing to Danjo, to just check it works. Should basically be the same that checks alfajores but pointin to danjo RPC
  • Double check contracts to see if there's something to change. Or document.

What i see is too many tasks that makes it unclear what this really is.

Am i mistaken?

Also if there are thing that needs to be post-deployment, let's create another isseu for that

@mcortesi mcortesi changed the title SocialConnect ready for Cel2 Verify SocialConnect ready for Cel2 Jul 23, 2024
@lvpeschke lvpeschke added todo: review tasklist question Further information is requested and removed todo: sync review labels Jul 23, 2024
@alecps
Copy link
Collaborator Author

alecps commented Jul 25, 2024

I agree with @mcortesi , I didn't write most of the original tasks and am not sure I understand all of them (update: I removed these tickets from the epic). ODIS depends on Forno, so this is really just a task to make sure Forno transitions to the L2 full node cleanly at migration time.

  • Ideally, services relying on forno should be able to keep the same URL, and forno will switch to the L2 network when the migration happens so ODIS will not need to do anything
  • State will be migrated to the L2, so we don't need to check that contracts are migrated
  • No one uses Alfajores ODIS, so we can test this during the alfajores migration

Nothing changes for ODIS as a result of the L2 migration except for the full node it talks to

If 'https://forno.celo.org/' is redirected to an L2 full node, and signers all rely on forno (which we can verify, added a ticket for this) then SocialConnect should work with Cel2 automatically

Of course, we'll want to test that ODIS and the SocialConnect contracts work on Dango and make sure MiniPay tests their setup e2e on a testnet as well. I added tickets for this.

@alecps
Copy link
Collaborator Author

alecps commented Jul 25, 2024

@lvpeschke I've removed all the extraneuous tasks from this epic. I'm not sure about the contractkit one. @soloseng can you add context there?

@lvpeschke
Copy link
Contributor

lvpeschke commented Sep 11, 2024

Hey all, could the tests on Dango happen ASAP to uncover any potential issues ASAP and decide how to tackle them, if any?
@alecps @martinvol @soloseng

@alecps
Copy link
Collaborator Author

alecps commented Sep 12, 2024

@lvpeschke for the tests to happen we need to point Alfajores ODIS to Dango (I can ask devops for this) and then just run our existing e2e tests against that instance.

This will cover

There are some other tickets here that I don't understand

@lvpeschke
Copy link
Contributor

@martinvol do you have more context about the above?

@soloseng
Copy link
Contributor

adding discussion thread regarding this issue

https://clabsco.slack.com/archives/CP5V8KF51/p1726158289642649

@martinvol
Copy link
Contributor

Pasting Alec update here
image

@alecps alecps changed the title Verify SocialConnect ready for Cel2 Verify SocialConnect ready for Alfajores L2 Migration Sep 23, 2024
@alecps alecps closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants