This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Consider changing DisruptorEventQueue.enqueue() to avoid possibility of blocking #1809
Labels
Comments
I created PR for this issue! : #1837 |
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
Apr 11, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
Apr 11, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
Apr 11, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
May 16, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
May 16, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
May 16, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
May 16, 2019
saiya
added a commit
to saiya/opencensus-java
that referenced
this issue
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Does it make sense to change DisruptorEventQueue.enqueue() to use RingBuffer.tryNext() instead of RingBuffer.next() to avoid possibly blocking in the case the producers overrun the consumer due to load or a future bug in the consumer?
In all of our use-cases our preference would be to drop the metrics rather than block.
opencensus-java/impl/src/main/java/io/opencensus/impl/internal/DisruptorEventQueue.java
Lines 130 to 142 in aa8ee6a
The text was updated successfully, but these errors were encountered: