You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I started to use ZipkingExporter with the BackgroundThreadTransport, I'd noticed some delay to export (as well as the increase of queue of spans, driving an increase of used memory from service) in services that generate spans with a high rate. Then I realised that the BackgroundThreadTransport constructor has two parameters, but it's not possible to set these parameters since the ZipkinExporter constructor receives a type of transport instead of an instance. For me, it seems that isn't possible to change the constructor parameters of this transport type, but in some cases it could be interesting.
For now, to cover my issue I change the constructor of ZipkingExporter (see below) as well as implementation of BackgroundThreadExporter (now it has a method to set the exporter instead of receive this on constructor).
I didn't open a pull request with this patch because I was in doubt if it's possible to change the transport parameters without the patch. Moreover, I just made the changes for ZipkinExporter. If this change makes sense, I can make the necessary modifications to cover all the exporter and then open a pull request.
Another thing is: for the BackgroundThreadTransport, beyond the max_batch_size, the _WAIT_PERIOD parameter may be interesting the possibility to change it.
The text was updated successfully, but these errors were encountered:
+1 for this, biting me as well. I think the grace_period parameter and max_batch_size really depend on the use case, and we should be able to specify those.
When I started to use ZipkingExporter with the BackgroundThreadTransport, I'd noticed some delay to export (as well as the increase of queue of spans, driving an increase of used memory from service) in services that generate spans with a high rate. Then I realised that the BackgroundThreadTransport constructor has two parameters, but it's not possible to set these parameters since the ZipkinExporter constructor receives a type of transport instead of an instance. For me, it seems that isn't possible to change the constructor parameters of this transport type, but in some cases it could be interesting.
For now, to cover my issue I change the constructor of ZipkingExporter (see below) as well as implementation of BackgroundThreadExporter (now it has a method to set the exporter instead of receive this on constructor).
I didn't open a pull request with this patch because I was in doubt if it's possible to change the transport parameters without the patch. Moreover, I just made the changes for ZipkinExporter. If this change makes sense, I can make the necessary modifications to cover all the exporter and then open a pull request.
Another thing is: for the BackgroundThreadTransport, beyond the
max_batch_size
, the_WAIT_PERIOD
parameter may be interesting the possibility to change it.The text was updated successfully, but these errors were encountered: