Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Commit

Permalink
Add go-cmp to install-tools target (#528)
Browse files Browse the repository at this point in the history
Use the general install-tools target so no one gets the vet failure if they follow the CONTRIBUTING.md instructions. Currently first attempt will fail with the download of go-cmp.
  • Loading branch information
Paulo Janotti authored Apr 22, 2019
1 parent 73558e6 commit 2b64001
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ test:
$(GOTEST) $(GOTEST_OPT) $(ALL_PKGS)

.PHONY: travis-ci
travis-ci: fmt install-go-cmp vet lint test-with-cover
travis-ci: fmt vet lint test-with-cover

.PHONY: test-with-cover
test-with-cover:
Expand Down Expand Up @@ -85,9 +85,6 @@ vet:
.PHONY: install-tools
install-tools:
go get golang.org/x/lint/golint

.PHONY: install-go-cmp
install-go-cmp:
go get -u github.com/google/go-cmp/cmp

.PHONY: agent
Expand Down

0 comments on commit 2b64001

Please sign in to comment.