-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol: standartize error codes, disconnect codes, client and subscription statuses throughout connectors #149
Comments
There are cases when client disconnected due to network conditions, timeout, etc. In these cases, there is no disconnect code from a server available. The simplest solution is providing 0 as code in disconnect context. But I suppose it may be better to standardize client-side codes for these situations:
All client-side disconnects except clean disconnect result in a reconnect. P.S. A good thing would be also think about client-side error codes. |
Possible client errors and codes:
|
Also, for the future would be great to standardize client connector statuses. One possible option is having:
Relates centrifugal/centrifuge-swift#27 |
And subscription statuses (not actual - see UPD below):
UPD: things evolved here a bit, current plan is to have:
|
Done in #221 |
If someone follows this issue – the current draft of standartized client API is in Centrifugo v4 WIP docs: Any feedback is appreciated – this is the future of Centrifuge and Centrifugo. |
At the moment we give access to string reason, but not to disconnect code. I suppose we should expose access to the
code
too.The text was updated successfully, but these errors were encountered: