Allow specification of liveness & readiness probes schemes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @igorcoding Thanks! You also need to bump https://github.com/centrifugal/helm-charts/blob/master/charts/centrifugo/Chart.yaml#L4 for CI release |
FZambia
reviewed
Nov 25, 2023
igorcoding
force-pushed
the
probes-scheme
branch
from
6725b0a to
fa6c7ae
Compare
igorcoding
force-pushed
the
probes-scheme
branch
from
fa6c7ae to
672b1a2
Compare
|
Hi @FZambia! Bumped Chart.yaml. If you have any comments - feel free to add. |
|
@igorcoding sorry for the delay - forgot about this PR.. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when enabling tls=true in the Centrifugo's config liveness and readiness probes also start serving using https. This PR adds ability to manage http probes' scheme (i.e. set it to HTTPS in case of enabled tls).