Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT service could pull asset manager address from the NFT contract itself #1372

Open
charleenfei opened this issue Apr 24, 2020 · 0 comments
Open

NFT service could pull asset manager address from the NFT contract itself #1372

charleenfei opened this issue Apr 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@charleenfei
Copy link
Contributor

currently, the asset manager address is passed in the constructor of a standard Asset NFT contract and kept in the NFT as a state var.

we could derive this address from the registry instead of having it passed in the MintNFTRequest payload. this would prevent mint fails from user error on the front end.
@charleenfei charleenfei added the enhancement New feature or request label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charleenfei