Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profit and loss report fixes #58

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Jan 28, 2025

Description

This pull request...

  • throws an error if metadata hash is not provided for cashflow, profitAndLoss and assetList reports
  • adds more tests for specific values comparing to production data

#

@sophialittlejohn sophialittlejohn added the alpha Include in alpha release label Jan 28, 2025
Copy link

Auto-bumped version for release, this cannot be the last commit as bots can't trigger the workflows to pass the PR checks

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (fb52d09) to head (b06aa39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   93.16%   93.22%   +0.06%     
==========================================
  Files          30       30              
  Lines        4313     4341      +28     
  Branches      445      450       +5     
==========================================
+ Hits         4018     4047      +29     
+ Misses        287      286       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophialittlejohn sophialittlejohn merged commit f75d455 into main Jan 28, 2025
8 checks passed
@sophialittlejohn sophialittlejohn deleted the improve-reports-data branch January 28, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Include in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants