Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use single set to keys for cephfs secrets #4935

Open
Madhu-1 opened this issue Oct 30, 2024 · 3 comments · May be fixed by #4988
Open

use single set to keys for cephfs secrets #4935

Madhu-1 opened this issue Oct 30, 2024 · 3 comments · May be fixed by #4988
Assignees
@black-dragon74
Labels
component/cephfs Issues related to CephFS good first issue Good for newcomers

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 30, 2024

Currently we have user and admin secret in cephfs secret

ceph-csi/examples/cephfs/secret.yaml

Lines 8 to 14 in 00c7fb3

# Required for statically provisioned volumes
userID: <plaintext ID>
userKey: <Ceph auth key corresponding to ID above>
# Required for dynamically provisioned volumes
adminID: <plaintext ID>
adminKey: <Ceph auth key corresponding to ID above>
. it would be good to use one user (user) instead of having two distinct keys for cephfs static/dynamic pvc.
@Madhu-1 Madhu-1 added the good first issue Good for newcomers label Oct 30, 2024
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 30, 2024

Required updates

  • Backward compatibility, fallback to user if adminID/adminKey not found for static pvc.
  • documentation update
  • testcase updates.

@nixpanic nixpanic added the component/cephfs Issues related to CephFS label Nov 1, 2024
@Madhu-1 Madhu-1 mentioned this issue Nov 19, 2024
Closed
@black-dragon74
Copy link
Member

/assign

@github-actions GitHub Actions
Copy link

Thanks for taking this issue! Let us know if you have any questions!

@iPraveenParihar iPraveenParihar linked a pull request Nov 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@black-dragon74 black-dragon74

Labels
component/cephfs Issues related to CephFS good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cephfs: use userid and keys for provisioning black-dragon74/ceph-csi
3 participants
@nixpanic @black-dragon74 @Madhu-1