Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cypress local setup #393

Closed
MJedr opened this issue Sep 21, 2023 · 1 comment
Closed

Improve cypress local setup #393

MJedr opened this issue Sep 21, 2023 · 1 comment
Assignees
@karolina-siemieniuk-morawska
Labels
e2e project: ui status: refined

Comments

@MJedr
Copy link

MJedr commented Sep 21, 2023

Running cypress locally is a nightmare, commands we use don't work anymore. That should be improved. Some of the issues are:

  • wrong image tag in cypress docker-compose (should be cypress/included:13)
  • wrong script name in cypress-tests.sh, maybe we should make it customisable to pass if we want to run chrome/firefox when executing script
  • on mac m1 chrome and firefox don't work with current test setup
@karolina-siemieniuk-morawska
Copy link
Collaborator

Tech notes:

  1. In docker-compose.cypress.dev.yml and docker-compose.cypress.yml change image version to cypress/included:13
  2. In cypress-test.sh change the last line to correct file names (cypress-tests-run-chrome and cypress-tests-run-firefox)
  3. Fix failing tests (author and literature submission - locally returns 50?, conference edit - missing legacy_ICN field, chrome - out of memory fail)
  4. Test thoroughly and fix flaky test cases

karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Jan 25, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
03b6338 
* ref: cern-sis/issues-inspire#393
Merged
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Jan 25, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
a4b1650 
* ref: cern-sis/issues-inspire#393
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Jan 29, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
e4f7b78 
* ref: cern-sis/issues-inspire#393
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Jan 30, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
7b55463 
* ref: cern-sis/issues-inspire#393
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Jan 30, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
dc08fcc 
* ref: cern-sis/issues-inspire#393
karolina-siemieniuk-morawska added a commit to inspirehep/inspirehep that referenced this issue Jan 31, 2024
@karolina-siemieniuk-morawska
e2e: improve local setup
d1c7328 
* ref: cern-sis/issues-inspire#393
@drjova drjova closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karolina-siemieniuk-morawska karolina-siemieniuk-morawska

Labels
e2e project: ui status: refined
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drjova @MJedr @karolina-siemieniuk-morawska