New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL push swallows exceptions #403

Closed

michamos opened this issue Oct 17, 2023 · 1 comment

Assignees

Labels

type: bug

Collaborator

michamos commented Oct 17, 2023

While looking at HAL push failures for Mathieu, I noticed that some failed pushes get flagged as successes. I believe the culprit is https://github.com/inspirehep/inspirehep/blob/cbd3c39f54eee1b4ab584d2dd966d6f0dd4a228f/backend/inspirehep/hal/tasks.py#L106-L110: we catch the exception and handle duplicate ids in a special way, but we don't reraise the exception in case it's not a duplicate ID, so it's handled as a success and not a failure down the line.

michamos added the type: bug label

drjova assigned MJedr

MJedr commented Nov 6, 2023

TECH
Add else branch here https://github.com/inspirehep/inspirehep/blob/cbd3c39f54eee1b4ab584d2dd966d6f0dd4a228f/backend/inspirehep/hal/tasks.py#L110 and raise a custom exception (sth like HALCreateException) with the custom message payload

drjova unassigned MJedr

PascalEgn mentioned this issue

hal: fix exception raise on _hal_create inspirehep/inspirehep#3123

Merged

PascalEgn self-assigned this

drjova closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment