Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display INSPIRE ID for authors that don't have an ORCID #431

Closed
michamos opened this issue Jan 11, 2024 · 1 comment
Closed

display INSPIRE ID for authors that don't have an ORCID #431

michamos opened this issue Jan 11, 2024 · 1 comment

Comments

@michamos
Copy link
Collaborator

When an author doesn't have an ORCID but has an INSPIRE ID, we should display the latter on the author profile. The data comes from ids.value where ids.schema is INSPIRE ID and should be displayed under Author identifier.

Mockup for https://inspirehep.net/authors/1010044:

Image

@karolina-siemieniuk-morawska
Copy link
Collaborator

TECH NOTES:

  1. In /authors, create new component InspireIdentifier.tsx similar to AuthorBAI.tsx and pass Inspire id as props
  2. In DetailPageContainer.tsx create logic to retrieve Inspire id from ids field and return it if there is no userOrcid prop present
  3. Here add the InspireIdentifier.tsx component when above conditions are met

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants