Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book chapters (with publication_info.parent_record field) are incorrectly displayed #445

Closed
michamos opened this issue Feb 9, 2024 · 1 comment
Assignees

Comments

@michamos
Copy link
Collaborator

michamos commented Feb 9, 2024

A user reports the following issue.

Consider the following example:

recid:2610328
On the origin of stellar energy
Lev Davidovich Landau
1937
2 pages
Part of Собрание трудов [Sobranie trudov]. Vol. 1, 333-334
Published in: Nature 141 (1938) 3564, 333-334, Compt.Rend.Acad.Sci.URSS 17 (1937) 6, 305-306, Dokl.Akad.Nauk SSSR 17 (1937) 6, 301-302
Published: Feb 19, 1938 and Published: 1937 and Published: 1965 in Oxford by Pergamon Press and Published: 1969 in Moscow by Наука [Nauka]
DOI: 10.1038/141333b0, 10.1016/b978-0-08-010586-4.50032-8

The string:

{"year":1965,"page_end":"186","page_start":"185","parent_isbn":"9780080105864","parent_record":{"$ref":"https://inspirehep.net/api/literature/2610294"},"curated_relation":true},
{"year":1969,"page_end":"226","page_start":"224","parent_record":{"$ref":"https://inspirehep.net/api/literature/2730766"},"curated_relation":true}

contained in:

https://inspirehep.net/api/literature/2610328

is not correctly dislayed in:

https://inspirehep.net/literature/2610328

The following 2 errors occur: The piece

{"year":1965,"page_end":"186","page_start":"185","parent_isbn":"9780080105864","parent_record":{"$ref":"https://inspirehep.net/api/literature/2610294"},"curated_relation":true},

is not displayed at all in https://inspirehep.net/literature/2610328.

The second piece

{"year":1969,"page_end":"226","page_start":"224","parent_record":{"$ref":"https://inspirehep.net/api/literature/2730766"},"curated_relation":true}

is displayed with the wrong page numbers (333-334 instead of 224-226; the page numbers 333-334 belong to the Nature
entry of the record).

This should be remedied.

@karolina-siemieniuk-morawska
Copy link
Collaborator

karolina-siemieniuk-morawska commented Feb 13, 2024

TECH NOTES:

  1. linked_book field should be renamed to linked_books and include all the publications that have parent_record field, not just the first one
  2. Apart from title and source fields it should also have page_start and page_end fields

karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 7, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 7, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 12, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 12, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 13, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 14, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 19, 2024
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Mar 19, 2024
@michamos michamos closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants