Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields from the backoffice #513

Closed
4 tasks done
drjova opened this issue Aug 6, 2024 · 1 comment
Closed
4 tasks done

Missing fields from the backoffice #513

drjova opened this issue Aug 6, 2024 · 1 comment

Comments

@drjova
Copy link
Contributor

drjova commented Aug 6, 2024

List of missing api with new structure:

  • Decision:

Image
Image

    {
         "user_action": "accept_curate” | “accept” | “reject”
    }
  • Snow ticket:

Image

    {
         “ticket”t_id: “”, 
         “ticket_url”: “”
    }
  • Error:

Image

    {
         “_error_msg”: “”
    }
  • Decision status: (“_message” || “_last_task_name”)

Image

    {
         “_message” || “_last_task_name”: “”
    }

I provided how it was in the previous data structure and how frontend currently expects it, if you decide to change structure let me know so I can handle it on ui.

Tasks

@drjova
Copy link
Contributor Author

drjova commented Aug 7, 2024

Decision

  • Probably we need another table to keep track of the actions

SNOW ticket:
We already have the model https://github.com/inspirehep/backoffice/blob/main/backoffice/backoffice/workflows/models.py#L36 we need to include it in the serializer and add an atrribute for ticket_url

Errors:
We just need to find a way to generate a URL to airflow with the errored task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants