Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author Update case #517

Closed
drjova opened this issue Aug 7, 2024 · 2 comments · Fixed by inspirehep/backoffice#69
Closed

Author Update case #517

drjova opened this issue Aug 7, 2024 · 2 comments · Fixed by inspirehep/backoffice#69
Assignees
@DonHaul @karolina-siemieniuk-morawska
Labels
project: backoffice project: ui

Comments

@drjova
Copy link
Contributor

drjova commented Aug 7, 2024 •
edited
Loading

Currently there's no endpoint to trigger and author update dag.

  • Create endpoint PUT api/workflows/authors/{id} that triggers the author_update_dag
  • Make sure whole dag runs successfully
  • Update the swagger
  • Make sure it works well with UI
@DonHaul DonHaul self-assigned this Aug 8, 2024
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 9, 2024
@DonHaul
author update: generic fixes
a772d98 
* ref: cern-sis/issues-inspire/issues/517
@DonHaul DonHaul mentioned this issue Aug 9, 2024
Merged
@karolina-siemieniuk-morawska
Copy link
Collaborator

TECH NOTES (for UI):

  1. On detail page update workflows should look exactly the same as new workflows
  2. On search page, the only indicator that it is an update should be a grey pill left of the name (same as author tag)
  3. Add new box on dashboard page for author's updates.

@DonHaul DonHaul linked a pull request Aug 9, 2024 that will close this issue
author update: generic fixes inspirehep/backoffice#69
Merged
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 9, 2024
@DonHaul
author update: generic fixes
2b0e269 
* ref: cern-sis/issues-inspire/issues/517
@DonHaul
Copy link
Collaborator

DonHaul commented Aug 9, 2024

In the end there was a update endpoint - its the same as the create endpoint. Fixed issues with dags

DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 9, 2024
@DonHaul
author update: generic fixes
0c23e00 
* ref: cern-sis/issues-inspire/issues/517
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 9, 2024
@DonHaul
author update: generic fixes
bbb682c 
* ref: cern-sis/issues-inspire/issues/517
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 9, 2024
@DonHaul
author update: generic fixes
4e42562 
* ref: cern-sis/issues-inspire/issues/517
karolina-siemieniuk-morawska added a commit to karolina-siemieniuk-morawska/inspirehep that referenced this issue Aug 13, 2024
@karolina-siemieniuk-morawska
ui: handle update author case
3e8383e 
* ref: cern-sis/issues-inspire#517
Merged
karolina-siemieniuk-morawska added a commit to inspirehep/inspirehep that referenced this issue Aug 13, 2024
@karolina-siemieniuk-morawska
ui: handle update author case
06dcc99 
* ref: cern-sis/issues-inspire#517
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 13, 2024
@DonHaul
author update: airflow dag fixes
b1c27dc 
* ref: cern-sis/issues-inspire/issues/517
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 14, 2024
@DonHaul
author update: airflow dag fixes
1eed97d 
* ref: cern-sis/issues-inspire/issues/517
drjova pushed a commit to inspirehep/backoffice that referenced this issue Aug 16, 2024
@DonHaul @drjova
author update: airflow dag fixes
ca6555d 
* ref: cern-sis/issues-inspire/issues/517
DonHaul added a commit to DonHaul/backoffice that referenced this issue Aug 19, 2024
@DonHaul
author update: airflow dag fixes
6bebc16 
* ref: cern-sis/issues-inspire/issues/517

destroy draft

destroy draft
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Sep 2, 2024
@DonHaul @drjova
author update: airflow dag fixes
2c726be 
* ref: cern-sis/issues-inspire/issues/517
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Sep 2, 2024
@DonHaul @drjova
author update: airflow dag fixes
d3d82fd 
* ref: cern-sis/issues-inspire/issues/517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonHaul DonHaul

@karolina-siemieniuk-morawska karolina-siemieniuk-morawska

Labels
project: backoffice project: ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

author update: generic fixes DonHaul/backoffice
3 participants
@drjova @DonHaul @karolina-siemieniuk-morawska