Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make record editor dynamic based on URL type #610

Open
drjova opened this issue Nov 12, 2024 · 0 comments
Open

make record editor dynamic based on URL type #610

drjova opened this issue Nov 12, 2024 · 0 comments

Comments

@drjova
Copy link
Contributor

drjova commented Nov 12, 2024

Currently, the record editor for the backoffice only supports the "authors" type, as seen in the example https://github.com/inspirehep/inspirehep/blob/681c501b7083edc00dc99cd5092acdeac700141c/record-editor/src/app/core/services/backoffice-api.service.ts#L110-L111

To improve flexibility, the record editor should be updated to handle various record types dynamically, similar to how the record and holdingpen editors operate. This can be achieved by utilizing the URL structure to identify the type dynamically. For instance, the editor endpoint could be formatted as follows:

editor/workflows/<type>/<uuid>

Acceptance Criteria:

Modify the record editor to accept and handle different parameters based on the URL structure.
Ensure support for multiple record types (e.g., authors, publications, etc.).
Maintain or improve existing tests to cover dynamic URL-based record type handling.
Ensure no regression for the existing "authors" type.

Additional Notes:

Review the existing logic in the record and holdingpen editors for guidance on implementing dynamic type handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant