Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with ticket URL in airflow #613

Closed
DonHaul opened this issue Nov 18, 2024 · 2 comments
Closed

Fix issues with ticket URL in airflow #613

DonHaul opened this issue Nov 18, 2024 · 2 comments
Assignees

Comments

@DonHaul
Copy link
Collaborator

DonHaul commented Nov 18, 2024

@michamos has reported issues creating authors:
https://inspirebeta.net/backoffice/5e4d9efe-7a01-4d56-9f13-383e14e20e1c

Upon checking https://workflows.inspire.dev.siscern.org/dags/author_create_initialization_dag/grid?execution_date=2024-11-15+16%3A38%3A51.264666%2B00%3A00&tab=logs&dag_run_id=5e4d9efe-7a01-4d56-9f13-383e14e20e1c&task_id=create_author_create_user_ticket
we see that the wrong url was being used for creating tickets

***   * /opt/airflow/logs/dag_id=author_create_initialization_dag/run_id=5e4d9efe-7a01-4d56-9f13-383e14e20e1c/task_id=create_author_create_user_ticket/attempt=1.log
[2024-11-15, 16:39:50 UTC] {local_task_job_runner.py:120} ▶ Pre task execution logs
[2024-11-15, 16:39:51 UTC] {base.py:84} INFO - Using connection ID 'inspire_connection' for task execution.
[2024-11-15, 16:39:51 UTC] {inspire_http_hook.py:54} INFO - Sending 'POST' to url: https://inspirebeta.net/api/tickets/create
[2024-11-15, 16:39:53 UTC] {author_create_init.py:77} INFO - Ticket created. Response status code: 200
[2024-11-15, 16:39:53 UTC] {author_create_init.py:78} INFO - {'ticket_id': 'bd94754787fd961095f833340cbb3504', 'ticket_url': 'https://cerntraining.service-now.com/nav_to.do?uri=/u_request_fulfillment.do?sys_id=bd94754787fd961095f833340cbb3504'}
[2024-11-15, 16:39:53 UTC] {base.py:84} INFO - Using connection ID 'backoffice_conn' for task execution.
[2024-11-15, 16:39:53 UTC] {base.py:59} INFO - Sending 'POST' to url: https://backoffice.dev.inspirebeta.net/api/workflow-ticket/
[2024-11-15, 16:39:53 UTC] {http.py:200} ERROR - HTTP error: Not Found
[2024-11-15, 16:39:53 UTC] {http.py:201} ERROR - 

We need to change from:

  • https://backoffice.dev.inspirebeta.net/api/workflow-ticket/
  • to https://backoffice.dev.inspirebeta.net/api/workflows/authors/tickets/

To avoid this issues in the future we need a centralized way to define routes, or alternatively end2end testing

@DonHaul
Copy link
Collaborator Author

DonHaul commented Nov 18, 2024

Upon checking the code, this is already properly implemented its just that even though we have autodeploy, the latest code is not on qa somehow

@DonHaul
Copy link
Collaborator Author

DonHaul commented Nov 18, 2024

Autodeploy is not being done for airflow hence the issue.

@DonHaul DonHaul self-assigned this Nov 18, 2024
@DonHaul DonHaul closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant