Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in new author workflow #614

Closed
6 of 7 tasks
michamos opened this issue Nov 18, 2024 · 4 comments · Fixed by inspirehep/inspirehep#3311
Closed
6 of 7 tasks

fix bugs in new author workflow #614

michamos opened this issue Nov 18, 2024 · 4 comments · Fixed by inspirehep/inspirehep#3311
Assignees
Labels
type: bug Something isn't working

Comments

@michamos
Copy link
Collaborator

michamos commented Nov 18, 2024

Testing of the new workflow by @michamos identified issues that should be fixed before further testing with outside curators

  • accepted with curation puts workflow in error: see https://inspirebeta.net/backoffice/5e4d9efe-7a01-4d56-9f13-383e14e20e1c
  • SNow ticket handling is wrong: on https://inspirebeta.net/backoffice/5e4d9efe-7a01-4d56-9f13-383e14e20e1c, the created ticket is wrong on several accounts (compare with prod): the title is incorrect, the functional category is incorrect, the description contains only a template but no payload, the initial ticket for the curator before the message for the user is missing, the user is not in the watchlist (and possibly more)
  • author update is stuck in running: https://inspirebeta.net/backoffice/10320bc2-d031-4834-824f-d5c2f4453fb8
  • page state in search is not part of the URL: this prevents linking of specific pages. Selection of facets and search query should be part of URL. This is probably not a blocker for authors (TBC), but should be fixed before adding other collections to the new backoffice.
  • page state is shared between multiple tabs: if you open two tabs, first one, say, with new authors, the other with author updates, then refresh the first tab, you'll get the content of the second tab
  • submission time (as opposed to date) is not visible in the metadata: it would be good to make the submission time visible too and order by full date-time. Probably not a blocker for authors.
  • changes take a long time to be visible: after approving an author, it took ~20s before it was displayed as running instead of approval. This is confusing, would it be possible to change the state immediately (potentially to something like waiting to be run if it takes some time for the workflow to start again)?
@michamos michamos added the type: bug Something isn't working label Nov 18, 2024
@DonHaul DonHaul self-assigned this Nov 18, 2024
DonHaul added a commit to inspirehep/inspirehep that referenced this issue Nov 18, 2024
@DonHaul
Copy link
Collaborator

DonHaul commented Nov 18, 2024

  1. api was not had been updated. To be fixed by https://github.com/inspirehep/inspirehep/compare/614-fix-bugs-in-new-author-workflow?expand=1
  2. awaiting e-group to check format.
  3. author_update_dag update dag was not turned on by default. .Do we want dags to be enabled by default?
  4. FE Issue
  5. FE Issue
  6. FE Issue

@michamos
Copy link
Collaborator Author

@DonHaul here are screenshots of service now

backoffice QA
Image

prod
Image

@drjova
Copy link
Contributor

drjova commented Nov 18, 2024

@DonHaul thank you, could you please make a PR for the 1st? As for the 3rd one, yes let's enable it for dev for now.

DonHaul added a commit to inspirehep/inspirehep that referenced this issue Nov 18, 2024
@michamos
Copy link
Collaborator Author

@DonHaul I've edited the description to add a new item (slow updates)

DonHaul added a commit to inspirehep/inspirehep that referenced this issue Nov 20, 2024
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 20, 2024
drjova added a commit to inspirehep/inspirehep that referenced this issue Nov 21, 2024
drjova added a commit to inspirehep/inspirehep that referenced this issue Nov 21, 2024
* Adds a `processing` state to the `AuthorWorkflow` model
  to indicate that the author is currently being processed
  without waiting the task to run.

* ref: cern-sis/issues-inspire#614
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 22, 2024
DonHaul added a commit to inspirehep/inspirehep that referenced this issue Nov 25, 2024
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 25, 2024
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 25, 2024
* ref: cern-sis/issues-inspire/issues/614

rough draft

	deleted:    workflows/dags/author/author_create/shared_tasks.py
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 25, 2024
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 25, 2024
drjova added a commit to inspirehep/inspirehep that referenced this issue Nov 25, 2024
* Adds a `processing` state to the `AuthorWorkflow` model
  to indicate that the author is currently being processed
  without waiting the task to run.

* ref: cern-sis/issues-inspire#614
@drjova drjova reopened this Nov 25, 2024
DonHaul added a commit to DonHaul/inspirehep that referenced this issue Nov 25, 2024
DonHaul added a commit to inspirehep/inspirehep that referenced this issue Nov 26, 2024
@drjova drjova closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants