Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_ticket deprecated #615

Open
DonHaul opened this issue Nov 19, 2024 · 2 comments
Open

create_ticket deprecated #615

DonHaul opened this issue Nov 19, 2024 · 2 comments

Comments

@DonHaul
Copy link
Collaborator

DonHaul commented Nov 19, 2024

create_ticket is deprecated (it comes as always false from the ui), simply use value, simply check if value is accept_curate if we wish to create a curation ticket.

@DonHaul DonHaul changed the title create_tickets deprecates create_ticket deprecated Nov 19, 2024
@drjova
Copy link
Contributor

drjova commented Nov 25, 2024

@DonHaul in which element are we using that?

@DonHaul
Copy link
Collaborator Author

DonHaul commented Nov 25, 2024

@DonHaul in which element are we using that?

We are not using it anywhere. It was already in the code.
My it was to use as an alternative to have "accept" and "accept_curate" but since we have both its not required.

being called here, but is always false
https://github.com/inspirehep/inspirehep/blob/a323f49e54e3fc943274fa978677203c7e2c73d6/ui/src/backoffice/containers/DetailPageContainer/AuthorDetailPageContainer.tsx#L78

was being used here, removed already to use accept_curate instead
https://github.com/inspirehep/inspirehep/pull/3312/files#diff-e47ee328b7d63956b8e7f1a4b4d29cdce54ed574b322f354edb6afcdd21557ebR72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants