From 2137343ced81cbf5495f6ee7d2bdf9db1d1f2f18 Mon Sep 17 00:00:00 2001
From: pamfilos <pamfilosf@gmail.com>
Date: Thu, 29 Aug 2024 12:23:25 +0200
Subject: [PATCH] oup: fixes bug for orcid parsing

Signed-off-by: pamfilos <pamfilosf@gmail.com>
---
 dags/oup/parser.py                 | 2 +-
 tests/units/oup/data/oup_orcid.xml | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/dags/oup/parser.py b/dags/oup/parser.py
index af6b79e1..b961dcfb 100644
--- a/dags/oup/parser.py
+++ b/dags/oup/parser.py
@@ -163,7 +163,7 @@ def _get_authors(self, article):
         )
         authors = []
         for contribution in contributions:
-            orcid = get_text_value(contribution.find("contrib-id"))
+            orcid = get_text_value(contribution.find("contrib-id[@contrib-id-type='orcid']"))
             surname = get_text_value(contribution.find("name/surname"))
             given_names = get_text_value(contribution.find("name/given-names"))
             email = get_text_value(contribution.find("email"))
diff --git a/tests/units/oup/data/oup_orcid.xml b/tests/units/oup/data/oup_orcid.xml
index 0ca9a8db..12c3643c 100644
--- a/tests/units/oup/data/oup_orcid.xml
+++ b/tests/units/oup/data/oup_orcid.xml
@@ -46,6 +46,7 @@
             </title-group>
             <contrib-group>
                 <contrib contrib-type="author">
+                    <contrib-id contrib-id-type="orc">https://orcid.org/0000-0002-7719-4155</contrib-id>
                     <contrib-id contrib-id-type="orcid">https://orcid.org/0000-0002-7719-4160</contrib-id>
                     <name>
                         <surname>Hong</surname>