Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the original function filterblq argument was lost when we refactored the code #22

Open
smouksassi opened this issue Sep 29, 2022 · 2 comments

Comments

@smouksassi
Copy link

olivierbarriere@c691c31#diff-1384b5ce45adcab039332f3a6cb6d613e1d6c01423d176ec92fe6f38eec9e9c2R43

this option can be useful when we want to equally filter out blq on obs and sim data before applying pred correction or further manipulation

opening this issue for sake of discussion on the best way forward

@PhilP86
Copy link

PhilP86 commented Oct 2, 2022

Indeed, this would be useful to include it as an argument in the censoring() function so that it lets the user decide whether observed bql should be set to -Inf or whether all bql (obs and sim) should be 'filtered out' by setting them to NA (setting them to NA instead of discarding them permitting to ensure dataframes for obs and all simulated replicates have the same dimension).

@billdenney
Copy link

With a quick thought on this (not looking through how things are handled in the code), here is what I would have expected using the functions provided:

I would expect the censoring() function to handle all BLQ (or ALQ) values and make them work correctly in any VPC that comes out of vpcstats(). In other words, I would think that filterblq would be implicit in using the censoring() function.

Is there a time when censoring() would be used that filterblq would be desired to be set to FALSE? (I can't think of one, but I've only thought about it for a few minutes.)

Generally, I think that if I give censoring() the desired output would have both the VPC for the continuous variable and the VPC for the fraction BLQ/ALQ by time would be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants