Having kit menu open while respawning clears all kits

[whizvox]

Description of the bug
If a player opens the kit menu while waiting to respawn and waits out the timer, the action of clearing the player's kit will also clear all items from the kit menu, rendering all other players unable to select any kits. Doing /kp reload will fix this, but only until someone else triggers the bug.

Screenshot of /kp debug

Additional screenshots or video (if applicable)

Can't select any kits

Pastebin.com of any relevant .yml files (if applicable)
n/a

[whizvox]

Update: this happens because of my plugins and configurations. EssentialsXSpawn was teleporting players to my hub world briefly, and Multiverse was setting their gamemode to adventure, allowing for this bug to occur at all. I can fix this on my end by using Multiverse to handle server spawn or disabling FancyDeath.

[cervinakuy]

Thanks for reporting. I was able to replicate this when only running KitPvP alone with FancyDeath enabled.

After debugging, I've determined this line is causing the problem:

KitPvP/src/main/java/com/planetgallium/kitpvp/listener/DeathListener.java

Line 159 in 6954f42

victim.getOpenInventory().getTopInventory().clear();

@D3adhkwen, you helped fix the original bug relating to the crafting inventory. How did you resolve this current issue as a result - did you change your original approach?

[Xemorr]

Thanks for reporting. I was able to replicate this when only running KitPvP alone with FancyDeath enabled.

After debugging, I've determined this line is causing the problem:

KitPvP/src/main/java/com/planetgallium/kitpvp/listener/DeathListener.java

Line 159 in 6954f42

victim.getOpenInventory().getTopInventory().clear();

@D3adhkwen, you helped fix the original bug relating to the crafting inventory. How did you resolve this current issue as a result - did you change your original approach?

Hey cervina, I've encountered this issue on a server I'm running too. I assume it's the same issue - I've just removed that line for my local build in the mean time.

[jph4991]

Thanks for reporting. I was able to replicate this when only running KitPvP alone with FancyDeath enabled.
After debugging, I've determined this line is causing the problem:

KitPvP/src/main/java/com/planetgallium/kitpvp/listener/DeathListener.java

Line 159 in 6954f42

victim.getOpenInventory().getTopInventory().clear();

@D3adhkwen, you helped fix the original bug relating to the crafting inventory. How did you resolve this current issue as a result - did you change your original approach?

Hey cervina, I've encountered this issue on a server I'm running too. I assume it's the same issue - I've just removed that line for my local build in the mean time.

How do you go about removing that line? I have the KitPVP Plugin, but don't see where I can remove that line. I am still having this issue

[Xemorr]

Thanks for reporting. I was able to replicate this when only running KitPvP alone with FancyDeath enabled.
After debugging, I've determined this line is causing the problem:

KitPvP/src/main/java/com/planetgallium/kitpvp/listener/DeathListener.java

Line 159 in 6954f42

victim.getOpenInventory().getTopInventory().clear();

@D3adhkwen, you helped fix the original bug relating to the crafting inventory. How did you resolve this current issue as a result - did you change your original approach?

Hey cervina, I've encountered this issue on a server I'm running too. I assume it's the same issue - I've just removed that line for my local build in the mean time.

How do you go about removing that line? I have the KitPVP Plugin, but don't see where I can remove that line. I am still having this issue

I used a bytecode editor called Recaf, it's not for the faint of heart

[D3adhkwen]

Sorry for missing the messages here, been rather busy irl. I've managed to simulate the issue locally and came up with a fix.
I sincerely apologize for missing out this handling in the initial fix.

[jph4991]

Thanks for reporting. I was able to replicate this when only running KitPvP alone with FancyDeath enabled.
After debugging, I've determined this line is causing the problem:

KitPvP/src/main/java/com/planetgallium/kitpvp/listener/DeathListener.java

Line 159 in 6954f42

victim.getOpenInventory().getTopInventory().clear();

@D3adhkwen, you helped fix the original bug relating to the crafting inventory. How did you resolve this current issue as a result - did you change your original approach?

Hey cervina, I've encountered this issue on a server I'm running too. I assume it's the same issue - I've just removed that line for my local build in the mean time.

How do you go about removing that line? I have the KitPVP Plugin, but don't see where I can remove that line. I am still having this issue

I used a bytecode editor called Recaf, it's not for the faint of heart

Are you able to link your updated file with the fix for me?