Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete: stop: unexposePorts code expects the daemon to be present #14

Closed
cfergeau opened this issue Nov 19, 2024 · 1 comment
Closed

Comments

@cfergeau
Copy link
Owner

At the end of crc delete, crc calls unexposePorts, which expects the crc daemon API for port forwarding to be available. This is not the case with macadam, at this time we expect gvproxy to be there for this. But gvproxy does not expose the needed API on the host, see containers/gvisor-tap-vsock#425

This will need to be fixed for a fully functional crc delete.

@cfergeau cfergeau changed the title delete: unexposePorts code expects the daemon to be present delete: stop: unexposePorts code expects the daemon to be present Nov 19, 2024
@cfergeau
Copy link
Owner Author

After switching to gvproxy, we don't need to unexpose anything as gvproxy will not be running when the virtual machine is not running.
The unexpose code has been removed in the "macadam" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant