Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation #4

Open
bensoltoff opened this issue Dec 10, 2016 · 0 comments
Open

Evaluation #4

bensoltoff opened this issue Dec 10, 2016 · 0 comments

Comments

@bensoltoff
Copy link

bensoltoff commented Dec 10, 2016

Evaluation of final project by Benjamin Soltoff

Topic Excellent Satisfactory Needs Work
Coding style x
Coding strategy x
Presentation: graphs x
Presentation: tables x
Achievement, creativity x
Ease of access x

Remarks:

  • Excellent intro to the topic. Well-developed, I can definitely see this turning into a master's thesis or research paper
  • For your interactive table on "Exploratory Analysis", this is my Anglo-American bias but could you also incorporate the English translation of each term in the table? You use the translated terms in the graphs on that page, why not in the table too?
  • To compare before/after term usage, could you present this in a single chart? Either a bar or line chart that shows the percentage or raw frequency change in term usage from before and after. Putting it into a single visualization would better communicate the pattern you are attempting to describe
  • You might want to explore using some sort of temporal LDA model that allows the topic structure to shift over time, rather than simply splitting the data into two chunks
  • Your shiny app is really fantastic. Unfortunately it just doesn't work well embedded in the site because the width of the site is too small. A link to it like you have in the navigation bar is probably sufficient. But my evaluation of hw10 stands - this is a great app!
  • The organization of the repo is a bit cluttered. Check out ChihYu and Shun's project repo for an alternative approach for storing and running R pipeline scripts and rendering the website
  • Don't store API keys in your repo. Those are private keys meant only to be used by the original user. Instead, provide instructions for individuals to obtain their own keys and integrate it into your pipeline so the scripts will run.
  • That said, the code itself is well documented. Very reproducible!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant