-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO in code references a closed issue #1176
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions. |
still an issue |
could this be related to #1027 (comment) ? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions. |
Updated in the latest version |
https://github.com/flutterchina/dio/blob/20506b496d41d7c2cc71d323e22634e99dc3ef21/dio/lib/src/adapters/browser_adapter.dart#L39
Appears to be referencing dart-lang/sdk#18542 . It looks like it was originally based on a version of the send method from browser_client.dart in dart2js that also contained this TODO:
https://chromium.googlesource.com/external/github.com/dart-lang/http/+/eb11c61e7bc14553e3256acafdb4d0096df18c27/lib/browser_client.dart#46
That issue was closed (as not a bug). The browser_client.dart code has since been refactored to properly use an arraybuffer:
https://chromium.googlesource.com/external/github.com/dart-lang/http/+/refs/heads/master/lib/src/browser_client.dart#44
The text was updated successfully, but these errors were encountered: