Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO in code references a closed issue #1176

Closed
deinspanjer opened this issue May 31, 2021 · 5 comments
Closed

TODO in code references a closed issue #1176

deinspanjer opened this issue May 31, 2021 · 5 comments

Comments

@deinspanjer
Copy link

https://github.com/flutterchina/dio/blob/20506b496d41d7c2cc71d323e22634e99dc3ef21/dio/lib/src/adapters/browser_adapter.dart#L39

Appears to be referencing dart-lang/sdk#18542 . It looks like it was originally based on a version of the send method from browser_client.dart in dart2js that also contained this TODO:
https://chromium.googlesource.com/external/github.com/dart-lang/http/+/eb11c61e7bc14553e3256acafdb4d0096df18c27/lib/browser_client.dart#46

That issue was closed (as not a bug). The browser_client.dart code has since been refactored to properly use an arraybuffer:
https://chromium.googlesource.com/external/github.com/dart-lang/http/+/refs/heads/master/lib/src/browser_client.dart#44

@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jul 1, 2021
@deinspanjer
Copy link
Author

still an issue

@stale stale bot removed the stale label Jul 2, 2021
@supermuesli
Copy link

could this be related to #1027 (comment) ?

@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2021
@wendux
Copy link
Contributor

wendux commented Nov 29, 2021

Updated in the latest version

@wendux wendux closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants