Fixing connection error

[abdelaziz-mahdy]

New Pull Request Checklist

• I have read the Documentation
• I have searched for a similar pull request in the project and found none
• I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
• I have added the required tests to prove the fix/feature I'm adding
• I have updated the documentation (if necessary)
• I have run the tests without failures
• I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

fixing #1911

[kuhnroyal]

Thanks for your contribution, I left a couple comments.

[kuhnroyal]

@cfug/devs In generell I am not sure if this should be considered a breaking change. I know I have code that relies on the current behaviour.

[kuhnroyal]

LGTM, just need to figure out if this will break peoples code.

[abdelaziz-mahdy]

LGTM, just need to figure out if this will break peoples code.

thank you for the fast and awesome review.

[AlexV525]

RSLGTM

[abdelaziz-mahdy]

Is something required from me other than the change log text review?

[AlexV525]

@kuhnroyal 's review is still requesting changes. PTAL

[abdelaziz-mahdy]

added the stacktrace

but this fails in the test

                (e) => e.stackTrace
                     .toString()
                    .contains('test/stacktrace_test.dart'),

since stacktrace is

#0      IOHttpClientAdapter._fetch (package:dio/src/adapters/io_adapter.dart:131:32)
<asynchronous suspension>
#1      CancelableCompleter.complete.<anonymous closure> (package:async/src/cancelable_operation.dart:425:16)
<asynchronous suspension>

so i commented it, should i remove it? or leave it so it gets tested when a better logic for stacktrace exists.

[kuhnroyal]

@cfug/devs In generell I am not sure if this should be considered a breaking change. I know I have code that relies on the current behaviour.

Any feedback on this?

[AlexV525]

@cfug/devs In generell I am not sure if this should be considered a breaking change. I know I have code that relies on the current behaviour.

Any feedback on this?

I would not consider this as a BC.

[abdelaziz-mahdy]

any idea when can this get merged?

[kuhnroyal]

We are not passing the original stacktrace for now, same as before this PR.
Further discussion for this in #1914

[kuhnroyal]

Thanks @zezo357 for your contribution and patience!