How to check condition for `No Internet Connection'

[rrifafauzikomara]

New Issue Checklist

• I have searched for a similar issue in the project and found none

Issue Description and Steps

How to check condition for No Internet Connection using DioErrorType?
The test case, when I turn off the wifi and mobile data.

Code

try {
      yield MoviesLoading();
      var movies = await repository.getNowPlaying(ApiConstant.apiKey, ApiConstant.language);
      if (movies.results.isEmpty) {
        yield MoviesNoData(AppConstant.noData);
      } else {
        yield MoviesHasData(movies);
      }
    } on DioError catch (e) {
      if (e.type == DioErrorType.CONNECT_TIMEOUT || e.type == DioErrorType.RECEIVE_TIMEOUT) {
        yield MoviesNoInternetConnection(AppConstant.noInternetConnection);
      } else {
        yield MoviesError(e.toString());
      }
    }

e.type == DioErrorType.CONNECT_TIMEOUT || e.type == DioErrorType.RECEIVE_TIMEOUT for handle Timeout, yield MoviesError(e.toString()); for handle Error from Dio. So how to handle No Internet Connection using DioError?

[jaydangar]

True this is the major problem dio is having, We can simply integrate Dio with connectivity package and before sending a request we can check for connection, if connection doesn't exists, then we can add a new DioError called NotConnectedException, which will give us the liberty to use it efficiently.

[rrifafauzikomara]

@jaydangar I don't recommend using connectivity package because If you are connected to wifi or mobile data but actually there is no internet data. The connectivity return true (has internet data). So I will not recommend it to check the internet connection. Because it's just to check the status not to check the internet connection.

[jaydangar]

There's another package called data_connection_checker which involved the exact thing we want.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

[ventr1x]

How is this automatically closed?
This is a major issue, especially for file uploads.

No connection results in the most unwanted behaviour possible:

• Dio "uploads" the entire file and actually updates the progress as if it is being uploaded (weird using UDP-style with no checks here, never ever seen that anywhere)
• Dio does not detect that there is in fact no connection
• Dio only reacts after the set overall timeout with an error

This behaviour is basically valid for any request, it just throws an error faster with smaller payload or GET requests.

To me this makes this package unusable outside the most simplest requests.
And using more plugins to wrap this one with correct functionality should not be the goal.

Dio simply does not implement the http correctly. There are e.g. options/pre-flight requests for exactly this reason.

[demetrio812]

Hello, any news on this issue? I agree this is a major issue, it's making me rethink about using Dio in my app

Thanks

[CARocha]

@demetrio812 yes this is a big problem i now i'm suffering and all my app writen wit Dio :/ i think change por http :/

[rrifafauzikomara]

Any progress?

[jorgoncalves]

@demetrio812 yes this is a big problem i now i'm suffering and all my app writen wit Dio :/ i think change por http :/

I'm also rethinking the use of Dio. I use it with Retrofit and not being able to handle the loss of internet, mid request or not, is making it hard to keep on using it.

[wandriputra]

Still no update for this issue?

[jgoyvaerts]

How is this automatically closed? This is a major issue, especially for file uploads.

No connection results in the most unwanted behaviour possible:

• Dio "uploads" the entire file and actually updates the progress as if it is being uploaded (weird using UDP-style with no checks here, never ever seen that anywhere)
• Dio does not detect that there is in fact no connection
• Dio only reacts after the set overall timeout with an error

This behaviour is basically valid for any request, it just throws an error faster with smaller payload or GET requests.

To me this makes this package unusable outside the most simplest requests. And using more plugins to wrap this one with correct functionality should not be the goal.

Dio simply does not implement the http correctly. There are e.g. options/pre-flight requests for exactly this reason.

Thanks for the feedback!

Since Dio is an open source project, we of course accept contributions in this area.

If you feel like the current implementation is lacking, feel free to create a pull request to improve it!

[ghost]

will this issue ever be resolved? I am suffering from this issue as well even on latest dio: ^5.3.2

[kuhnroyal]

If you think this needs improvement, please open a new ticket with a reproducible test case. But I don't think there is much dio can do.