Fixing connection error

dio/CHANGELOG.md

@@ -6,7 +6,9 @@ See the [Migration Guide][] for the complete breaking changes list.**
 ## Unreleased
 
 *None.*
+## 5.3.2
 
+- Fixing requests failing with unknown instead of connection error on SocketException
 ## 5.3.1
 
 - Improve package descriptions and code formats.

dio/lib/src/adapters/io_adapter.dart

@@ -116,7 +116,11 @@ class IOHttpClientAdapter implements HttpClientAdapter {
       });
     } on SocketException catch (e) {
       if (!e.message.contains('timed out')) {
-        rethrow;
+        throw DioException.connectionError(
+          requestOptions: options,
+          reason: e.message,
+          error: e,
+        );
       }
       throw DioException.connectionTimeout(
         requestOptions: options,

dio/lib/src/dio_exception.dart

@@ -151,14 +151,14 @@ class DioException implements Exception {
   factory DioException.connectionError({
     required RequestOptions requestOptions,
     required String reason,
+    Object? error,
   }) =>
       DioException(
-        type: DioExceptionType.connectionError,
-        message: 'The connection errored: $reason',
-        requestOptions: requestOptions,
-        response: null,
-        error: null,
-      );
+          type: DioExceptionType.connectionError,
+          message: 'The connection errored: $reason',
+          requestOptions: requestOptions,
+          response: null,
+          error: error);
 
   /// The request info for the request that throws exception.
   final RequestOptions requestOptions;

dio/pubspec.yaml

@@ -1,5 +1,5 @@
 name: dio
-version: 5.3.1
+version: 5.3.2
 
 description: |
   A powerful HTTP networking package,

dio/test/basic_test.dart

@@ -44,11 +44,7 @@ void main() {
       throwsA(
         allOf([
           isA<DioException>(),
-          (DioException e) =>
-              e.type ==
-              (isWeb
-                  ? DioExceptionType.connectionError
-                  : DioExceptionType.unknown),
+          (DioException e) => e.type == (DioExceptionType.connectionError),
           if (!isWeb) (DioException e) => e.error is SocketException,
         ]),
       ),

dio/test/stacktrace_test.dart

@@ -205,59 +205,58 @@ void main() async {
       },
       testOn: '!browser',
     );
-
-    group('DioExceptionType.unknown', () {
+    group('DioExceptionType.connectionError', () {
       test(
-        JsonUnsupportedObjectError,
+        'SocketException on request',
         () async {
-          final dio = Dio()..options.baseUrl = 'https://does.not.exist';
-
+          final dio = Dio()
+            ..options.baseUrl = 'https://does.not.exist'
+            ..httpClientAdapter = IOHttpClientAdapter();
           await expectLater(
-            dio.get(
-              '/test',
-              options: Options(contentType: Headers.jsonContentType),
-              data: Object(),
-            ),
+            dio.get('/test', data: 'test'),
             throwsA(
               allOf([
                 isA<DioException>(),
-                (DioException e) => e.type == DioExceptionType.unknown,
-                (DioException e) => e.error is JsonUnsupportedObjectError,
-                (DioException e) => e.stackTrace
+                (e) => e.type == DioExceptionType.connectionError,
+                (e) => e.error is SocketException,
+                (e) => (e.error as SocketException)
+                    .message
+                    .contains("Failed host lookup: 'does.not.exist'"),
+                (e) => e.stackTrace
                     .toString()
                     .contains('test/stacktrace_test.dart'),
               ]),
             ),
           );
         },
-        testOn: '!browser',
+        testOn: 'vm',
       );
-
+    });
+    group('DioExceptionType.unknown', () {
       test(
-        'SocketException on request',
+        JsonUnsupportedObjectError,
         () async {
-          final dio = Dio()
-            ..options.baseUrl = 'https://does.not.exist'
-            ..httpClientAdapter = IOHttpClientAdapter();
+          final dio = Dio()..options.baseUrl = 'https://does.not.exist';
 
           await expectLater(
-            dio.get('/test', data: 'test'),
+            dio.get(
+              '/test',
+              options: Options(contentType: Headers.jsonContentType),
+              data: Object(),
+            ),
             throwsA(
               allOf([
                 isA<DioException>(),
-                (e) => e.type == DioExceptionType.unknown,
-                (e) => e.error is SocketException,
-                (e) => (e.error as SocketException)
-                    .message
-                    .startsWith("Failed host lookup: 'does.not.exist'"),
-                (e) => e.stackTrace
+                (DioException e) => e.type == DioExceptionType.unknown,
+                (DioException e) => e.error is JsonUnsupportedObjectError,
+                (DioException e) => e.stackTrace
                     .toString()
                     .contains('test/stacktrace_test.dart'),
               ]),
             ),
           );
         },
-        testOn: 'vm',
+        testOn: '!browser',
       );
 
       test(

plugins/native_dio_adapter/.flutter-plugins

@@ -0,0 +1,3 @@
+# This is a generated file; do not edit or check into version control.
+cronet_http=/Users/AbdelazizMahdy/.pub-cache/hosted/pub.dev/cronet_http-0.2.1/
+cupertino_http=/Users/AbdelazizMahdy/.pub-cache/hosted/pub.dev/cupertino_http-1.0.1/

plugins/native_dio_adapter/.flutter-plugins-dependencies

@@ -0,0 +1 @@
+{"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"cupertino_http","path":"/Users/AbdelazizMahdy/.pub-cache/hosted/pub.dev/cupertino_http-1.0.1/","native_build":true,"dependencies":[]}],"android":[{"name":"cronet_http","path":"/Users/AbdelazizMahdy/.pub-cache/hosted/pub.dev/cronet_http-0.2.1/","native_build":true,"dependencies":[]}],"macos":[{"name":"cupertino_http","path":"/Users/AbdelazizMahdy/.pub-cache/hosted/pub.dev/cupertino_http-1.0.1/","native_build":true,"dependencies":[]}],"linux":[],"windows":[],"web":[]},"dependencyGraph":[{"name":"cronet_http","dependencies":[]},{"name":"cupertino_http","dependencies":[]}],"date_created":"2023-07-31 23:02:58.574313","version":"3.10.6"}