Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SUBROUTINE and FUNCTION argument typespec explicitely in HELP #24

Open
jnsebgosselin opened this issue Nov 1, 2018 · 0 comments · May be fixed by #50
Open

Define SUBROUTINE and FUNCTION argument typespec explicitely in HELP #24

jnsebgosselin opened this issue Nov 1, 2018 · 0 comments · May be fixed by #50
Assignees
Labels
tag: HELP modifs When a PR or Issue inply changes to the FORTRAN base code of HELP type: bug Something isn't working
Milestone

Comments

@jnsebgosselin
Copy link
Member

As mentionned in #22 (comment), arguments of each SUBROUTINE or FUNCTION should be explicitly defined. This is to avoid warning or the type vars2fortran: No typespec for argument "nt". Block: leap when compiling with f2py.

For example, the SUBROUTINE READIN does not produce such a warnings.

C      ************************* READIN *************************
C
C  SUBROUTINE READIN READS ET AND SOIL DESIGN DATA, AND WEATHER HEADERS
C
      SUBROUTINE READIN (fpath_precip, fpath_tasavg, fpath_solrad,
     1 fpath_evapo, fpath_soil)
      
      CHARACTER(len=260), INTENT(IN) :: fpath_precip
      CHARACTER(len=260), INTENT(IN) :: fpath_tasavg
      CHARACTER(len=260), INTENT(IN) :: fpath_solrad
      CHARACTER(len=260), INTENT(IN) :: fpath_evapo
      CHARACTER(len=260), INTENT(IN) :: fpath_soil

So I think this can be safely ignored for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: HELP modifs When a PR or Issue inply changes to the FORTRAN base code of HELP type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant