Skip to content

Commit

Permalink
install: Drop code/test uses of --security-opt
Browse files Browse the repository at this point in the history
We think this is unnecessary now; part of improving
the ergonomics of `bootc install` in general, but
especially with the `to-existing-root` path.

Once this lands, at some point later then we
can also remove it from all of the documentation.
But the most safe thing is to leave it in the
docs for a bit longer.

Closes: containers#928

Signed-off-by: Colin Walters <[email protected]>
  • Loading branch information
cgwalters committed Dec 9, 2024
1 parent a89fe65 commit bcdac01
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion ostree-ext/.github/workflows/bootc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Integration tests
run: |
set -xeuo pipefail
sudo podman run --rm -ti --privileged -v ./usr/bin/bootc:/usr/bin/bootc --pid=host --security-opt label=disable \
sudo podman run --rm -ti --privileged -v ./usr/bin/bootc:/usr/bin/bootc --pid=host \
quay.io/centos-bootc/centos-bootc-dev:stream9 bootc install to-filesystem \
--karg=foo=bar --disable-selinux --replace=alongside /target
10 changes: 1 addition & 9 deletions tests-integration/src/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,7 @@ use fn_error_context::context;
use libtest_mimic::Trial;
use xshell::{cmd, Shell};

pub(crate) const BASE_ARGS: &[&str] = &[
"podman",
"run",
"--rm",
"--privileged",
"--pid=host",
"--security-opt",
"label=disable",
];
pub(crate) const BASE_ARGS: &[&str] = &["podman", "run", "--rm", "--privileged", "--pid=host"];

// Arbitrary
const NON_DEFAULT_STATEROOT: &str = "foo";
Expand Down

0 comments on commit bcdac01

Please sign in to comment.