Skip to content

Commit

Permalink
Wrong data type, this fix generate correct metrics for Latency, Error…
Browse files Browse the repository at this point in the history
…, and Fault (aws#403)
  • Loading branch information
Paramadon authored Apr 17, 2024
1 parent c638bfa commit ff4892e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
13 changes: 7 additions & 6 deletions test/app_signals/resources/metrics/client_producer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"metrics": [
{
"name": "Error",
"unit": "Milliseconds",
"sum": {
"unit": "",
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -87,8 +87,8 @@
},
{
"name": "Fault",
"unit": "Milliseconds",
"sum": {
"unit": "",
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -141,7 +141,7 @@
{
"name": "Latency",
"unit": "Milliseconds",
"sum": {
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -196,4 +196,5 @@
]
}
]
}
}

17 changes: 9 additions & 8 deletions test/app_signals/resources/metrics/server_consumer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"metrics": [
{
"name": "Error",
"unit": "Milliseconds",
"sum": {
"unit": "",
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -93,8 +93,8 @@
},
{
"name": "Fault",
"unit": "Milliseconds",
"sum": {
"unit": "",
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -153,7 +153,7 @@
{
"name": "Latency",
"unit": "Milliseconds",
"sum": {
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -212,7 +212,7 @@
{
"name": "Latency",
"unit": "Milliseconds",
"sum": {
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -271,7 +271,7 @@
{
"name": "Latency",
"unit": "Milliseconds",
"sum": {
"exponential_histogram": {
"dataPoints": [
{
"attributes": [
Expand Down Expand Up @@ -332,4 +332,5 @@
]
}
]
}
}

0 comments on commit ff4892e

Please sign in to comment.