Skip to content

Commit

Permalink
chore: remove cosign for signing attestations (#1824)
Browse files Browse the repository at this point in the history
Signed-off-by: Jose I. Paris <[email protected]>
  • Loading branch information
jiparis authored Feb 18, 2025
1 parent fd7fc90 commit 561e456
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,7 @@ jobs:
if: ${{ success() && github.event_name != 'pull_request' }}
run: |
chainloop attestation status --full
chainloop attestation push --key env://CHAINLOOP_SIGNING_KEY
env:
CHAINLOOP_SIGNING_PASSWORD: ${{ secrets.COSIGN_PASSWORD }}
CHAINLOOP_SIGNING_KEY: ${{ secrets.COSIGN_KEY }}
chainloop attestation push
- name: Mark attestation as failed
if: ${{ failure() && github.event_name != 'pull_request' }}
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/github_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
secrets:
chainloop_token:
required: true
cosign_key:
required: true
cosign_pass:
required: true

permissions: {}

Expand Down Expand Up @@ -67,13 +63,10 @@ jobs:
if: ${{ success() }}
run: |
chainloop attestation status --full
attestation_sha=$(chainloop attestation push --key env://CHAINLOOP_SIGNING_KEY -o json | jq -r '.digest')
attestation_sha=$(chainloop attestation push -o json | jq -r '.digest')
# check that the command succeeded
[ -n "${attestation_sha}" ] || exit 1
echo "attestation_sha=$attestation_sha" >> $GITHUB_OUTPUT
env:
CHAINLOOP_SIGNING_PASSWORD: ${{ secrets.cosign_pass }}
CHAINLOOP_SIGNING_KEY: ${{ secrets.cosign_key }}
- name: Mark attestation as failed
if: ${{ failure() }}
Expand Down

0 comments on commit 561e456

Please sign in to comment.