Menu trigger does not work in tests

[bohdanbirdie]

🐛 Bug report

Originally coming from the use of ParkUI, but I narrowed down the bug to zag.
When using Menu component and running tests on it, specifically calling userEvent.click() on trigger - preventDefault is causing the menu not to open.

Exact source:

zag/packages/machines/menu/src/menu.connect.ts

Line 197 in a58f2d0

event.preventDefault()

If I manually remove preventDetault() call in node_modules then it works all right.

As an experiment, I created a plain button in React and added onPointerDown and onClick events. When click is triggered with userEvent.click the onPointerDown is called first and then onClick after it. But preventing default forces onClick to never be called.
I doubt that issue is on the side of react-testing-library as it works fine with plain HTML buttons. They simulate the click the same was it's done by user. If you add events onClick={console.log} onPointerDown={console.log} to the Menu.Trigger you will see that both events were triggered by manually clicking the button.

💥 Steps to reproduce

1. Get the reproduction project
2. npm install
3. npm run test
4. Observe that tests failed as menu was not opened after a click
5. npx patch-package to apply patch on the source code
6. npm run test
7. Observe that tests passed as now menu is opened

💻 Link to reproduction

Whore repro project:
https://github.com/bohdanbirdie/zag-events

Specific test:
https://github.com/bohdanbirdie/zag-events/blob/main/src/App.test.tsx

🧐 Expected behavior

ProinterDown even is not prevented on default behavior.

🧭 Possible Solution

Remove prevent default call.

🌍 System information

[email protected] /Users/bohdanptyts/dev/repos/zag-events/zag-events
├─┬ @ark-ui/[email protected]
│ └── @zag-js/[email protected]
└─┬ @park-ui/[email protected]
└─┬ @ark-ui/[email protected]
└── @zag-js/[email protected]

Software	Version(s)
Zag Version	above
Browser	Any, also JSDom
Operating System	MacOS

[bohdanbirdie]

Current workaround is to use fireEvent instead of userEvent as it directly triggers click event.

[segunadebayo]

We faced this as well in Ark UI. We'll need to check the side effects of removing that prevent default call.

For now, please use the fireEvent instead.