Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filedragenter/filedragleave are both emitted whilst in the drop zone #6

Open
Conceptiks opened this issue Jan 6, 2022 · 2 comments

Comments

@Conceptiks
Copy link

Conceptiks commented Jan 6, 2022

First mentioned here: #5
From what I can understand from the docs, I think filedragenter and filedragleave are emitted too often.

I assume that filedragenter should only be emitted once, when the user's cursor enters the dropzone while dragging some files. The reverse should be true for filedragleave.

In this REPL (fixed), you can observe the console logs by opening your DevTools. If you drag some files to the drop zone (don't release) and start moving your mouse up and down inside the drop zone, events are emitted (both enter and leave events).

@chanced
Copy link
Owner

chanced commented Jan 7, 2022

It seems to be caused by a dragenter/dragleave event firing for each element within the container. I'll get it fixed as soon as I get a chance.

Thank you for reporting it and for the repl.

@chanced
Copy link
Owner

chanced commented May 31, 2023

Ugh, I apologize I forgot about this.

@chanced chanced reopened this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants