Add truncated props in Badge #2603
Open
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87747dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 145 145
Lines 2889 2889
Branches 920 920
=======================================
Hits 2365 2365
+ Misses 520 494 -26
- Partials 4 30 +26 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
nayounsang
commented
Feb 8, 2025
| @@ -24,3 +32,16 @@ export const Primary: StoryObj<BadgeProps> = { | |||
| variant: 'default', | |||
There was a problem hiding this comment.
Primary에서도 배포버전에서 truncated: set object 의 control이 생깁니다. 없앨 예정입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
Related Issue
Fixes #2591
Summary
Details
truncatedprops to Badge and added the story of truncated Badge. It supports ellipses in Badge text.widthmust be specified from the outside or on itself. Otherwise, even iftruncatedprops are specified, the length will increase because offlex.Breaking change? (Yes/No)
No
References