Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support querying for UBERON ancestors of CL ontology terms #252

Open
nayib-jose-gloria opened this issue Dec 2, 2024 · 1 comment

Comments

@nayib-jose-gloria
Copy link
Collaborator

nayib-jose-gloria commented Dec 2, 2024

Need

Is your feature request related to a problem? Please describe.

  • I would like to use get_highest_level_term (and related functions) to map CL terms to their UBERON ancestors (i.e. terms in the tissue_general list).

Approach

Describe the solution you'd like

  • I would like to be able to query for UBERON ancestors of CL terms
  • I would also like to be able to optionally exclude terms from different ontologies when querying for ancestors
  • Since UBERON has its own term graph generated by the builder, consider whether it makes more sense to: merge the CL/UBERON graphs on common terms vs. keep them separate and require specifying which you are querying vs. provide the option to query either a merged or distinct graph where applicable.
  • If any function signature undergoes a breaking change as a result, release a MAJOR version of COG and communicate to consumers
  • As such, seriously consider impacts of changing existing function signatures vs. adding a new one to support the new user-case
@ejmolinelli
Copy link
Contributor

I would like to be able to query for UBERON ancestors of CL terms

This functionality should be supported here.

To use this, the ontology_info.json would need to be updated with the aditional_ontologies field. For example,

"UBERON": {
        "version": "v2024-08-07",
        "source": "https://github.com/obophenotype/uberon/releases/download",
        "filename": "uberon.owl",
        "allowed_ontologies": ["UBERON","CL"]
      },

[!NOTE] Edge Case
The logic encoded here is not safe for non obo terms. When interpreted by OwlReady2 terms from non-obo ontologies will not have the natural prefix in their name such as "EFO_XXXX" -> "EFO:XXXX". This is an edge case, but be aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants