Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/segmentation mask #16

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Patch/segmentation mask #16

merged 4 commits into from
Aug 15, 2024

Conversation

seankmartin
Copy link
Collaborator

Introduces two fixes to the existing segmentation code:

  1. The block encoding was happening before padding, this has been corrected.
  2. The chunk size could cause issues for non-cube chunk sizes. This was due to the chunk being written in Z, Y, X order, but neuroglancer expecting X, Y, Z

aranega
aranega approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks really good to me :) Thanks a lot @seankmartin !

@seankmartin seankmartin merged commit 289f28d into main Aug 15, 2024
4 checks passed
@seankmartin seankmartin deleted the patch/segmentation_mask branch August 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranega aranega aranega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seankmartin @aranega