Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cmd + Left Click on links in table rows causes primary action to be executed as well as opening new tab #1301

Closed
uermel opened this issue Nov 5, 2024 · 1 comment · Fixed by #1335
Labels
bug Something isn't working

Comments

@uermel
Copy link
Contributor

uermel commented Nov 5, 2024

Describe the bug
When Cmd + left-clicking on hyperlinked text in table rows (e.g. the run name in the "single dataset page" table or the dataset name in the "all datasets" table), a new tab is opened, but the primary action (i.e. going to that run's/dataset's page is still executed).

My expectation would be that no action is executed on the current page when I Cmd+Left Click a link, and instead a new tab is opened. This is useful when one wants to quickly open many runs/datasets at the same time without navigating.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any Single Dataset Page (e.g. 10114)
  2. Hold Cmd and left click any run

Screenshots
https://github.com/user-attachments/assets/5f7b665b-6b40-440a-90f3-80c35c5b3ce0

Desktop (please complete the following information):

  • OS: MacOS 15.1
  • Browser Chrome 130.0.6723.92
@uermel uermel added the bug Something isn't working label Nov 5, 2024
@uermel uermel changed the title Bug: Cmd + Left Click on table items causes primary action to be executed as well as opening new tab Bug: Cmd + Left Click on links in table rows causes primary action to be executed as well as opening new tab Nov 5, 2024
@codemonkey800
Copy link
Contributor

thank you @daniel-ji for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants