fix: Modifier (cmd, shift, ctrl) clicking on BaseLink Links modifies current page view & url
#1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ffff sorry @daniel-ji I've been out on PTO for a bit haha let me inspect what's going on with the CI |
|
okay actually looks unrelated and I remember the E2E doesn't work for at the moment. let me merge it and monitor the E2Es for staging. thank you!! 🫶 |
github-actions bot
added a commit
that referenced
this pull request
Nov 27, 2024
🤖 I have created a release *beep* *boop* --- ## [1.36.1](web-v1.36.0...web-v1.36.1) (2024-11-27) ### 🐞 Bug Fixes * duplicate funding agencies ([#1365](#1365)) ([544297c](544297c)) * fix datasets with deposition data typo ([#1358](#1358)) ([c5033c4](c5033c4)) * Modifier (cmd, shift, ctrl) clicking on `BaseLink` Links modifies current page view & url ([#1335](#1335)) ([aed70fb](aed70fb)) ### 🧹 Miscellaneous Chores * update deps ([#1361](#1361)) ([d9f6635](d9f6635)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1301.
This fix intercepts the click event and stops event propagation on the current tab (what causes the view to change). Covers all bases with event propagation (both native and synthetic events).