Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create validation for only one tomogram to be is_visualization_default #1339

Open
manasaV3 opened this issue Nov 13, 2024 · 1 comment
Open
Labels
backend P1 Should have

Comments

@manasaV3
Copy link
Contributor

Motivation

This is_visualization_default flag for a tomogram can be set to true for multiple tomograms in a run. This changes the meaning of the flag, from being the flag to identify the tomogram whose key photo and neuroglancer config are to be used, to a flag that is unique for a run, given a deposition.

Currently, there are no validations to ensure if there is more than one tomogram having is_visualization_default is true.
In the case where a deposition adds tomograms to a run, it could potentially have a tomogram marked as is_visualization_default is true, we can run into a case with multiple tomograms having the is_visualization default set to true.

This could potentially create a non-deterministic experiences when getting the first tomogram with is_visualization_default=true.

Definition of Done

There is only one tomogram with is_visualization_default=true for every run.

Tasks

  • Add tests in validation which checks for this criteria.
  • Fix any configs and reingest the tomogram metadata

Notes

The frontend should currently be handling for this with a sort on is_author_submitted, to prioritize the author submitted tomogram.

@manasaV3
Copy link
Contributor Author

Blocked by: #1331

@manasaV3 manasaV3 added the P1 Should have label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend P1 Should have
Projects
None yet
Development

No branches or pull requests

1 participant