Result refactor #23
Open
Result refactor #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
has been updated against master ~2.6.4. Any chance of some attention? |
rcoup
force-pushed
the
result-refactor
branch
from
8a1e4b5 to
a351c89
Compare
|
Updated again against 2.7.1 |
Uses the Model.fields[0] by default, but can be overridden via `Model.repr_field`
* move sub type & dependent type declarations to the model classes * dependent_sub_types moves to the sub type classes themselves * simplify construct/init_* methods
rcoup
force-pushed
the
result-refactor
branch
from
a351c89 to
e3ce01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13, which leads directly to easier mocking/testing of Chargebee APIs too.
It's mostly just cut & paste from result.py to the model classes. The
Result._get*()methods no longer pass sub_types/etc toModel__init__(), because they're already defined on the class.Model.init_dependent_*()methods are no longer called fromResult, they're integrated intoModel.construct(), and are simpler because there's no need to find and pass the dependent's subtypes.I've added a test for subtypes using Customer, and a test for Estimate which was the only model using dependent_types.
(includes PR #22, but can refactor if/once that lands)