Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review: Reduced C Matrix and Dynamical Matrix #4

Open
charlesdavid opened this issue May 16, 2018 · 0 comments
Open

Code Review: Reduced C Matrix and Dynamical Matrix #4

charlesdavid opened this issue May 16, 2018 · 0 comments

Comments

@charlesdavid
Copy link
Owner

I am requesting a code review of the formulae used to compute the reduced c-matrices and reduced dynamical matrices. The two methods are in the class PCA.java: static Matrix get_reduced_C_matrix(Matrix Q), and static Matrix get_reduced_DYN_matrix(Matrix DYN). The key lines of code are:
double cov = (Q.get(a1, b1) + Q.get(a2, b2) + Q.get(a3, b3));
double dyn = -(DYN.get(a1, b1) + DYN.get(a2, b2) + DYN.get(a3, b3));
The original formulae were written in a vectorized form for Matlab, so I want to be sure that the conversion to the component version here is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant