You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am requesting a code review of the formulae used to compute the reduced c-matrices and reduced dynamical matrices. The two methods are in the class PCA.java: static Matrix get_reduced_C_matrix(Matrix Q), and static Matrix get_reduced_DYN_matrix(Matrix DYN). The key lines of code are: double cov = (Q.get(a1, b1) + Q.get(a2, b2) + Q.get(a3, b3)); double dyn = -(DYN.get(a1, b1) + DYN.get(a2, b2) + DYN.get(a3, b3));
The original formulae were written in a vectorized form for Matlab, so I want to be sure that the conversion to the component version here is correct.
The text was updated successfully, but these errors were encountered:
I am requesting a code review of the formulae used to compute the reduced c-matrices and reduced dynamical matrices. The two methods are in the class PCA.java: static Matrix get_reduced_C_matrix(Matrix Q), and static Matrix get_reduced_DYN_matrix(Matrix DYN). The key lines of code are:
double cov = (Q.get(a1, b1) + Q.get(a2, b2) + Q.get(a3, b3));
double dyn = -(DYN.get(a1, b1) + DYN.get(a2, b2) + DYN.get(a3, b3));
The original formulae were written in a vectorized form for Matlab, so I want to be sure that the conversion to the component version here is correct.
The text was updated successfully, but these errors were encountered: