You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the FullHelpView function, the spaces within the columns created by lipgloss.JoinHorizontal do not have dedicated style options. This results in inconsistent styling, especially when a background color is applied to the terminal. As shown in the attached screenshot, the spaces remain unstyled with no ability to apply custom styles, leading to visual discrepancies.
This issue is similar to the one described in issue #571, where the ShortHelpView function lacks style options for spaces between the key and description.
Screenshot:
To resolve this issue, I suggest wrapping the JoinHorizontal call in a Render call of the FullSeparator style. This would allow the other styles to override anything not set by the FullSeparator style, effectively styling the whitespace.
If you settle on an approach, I'm happy to implement it and provide a PR. Thanks again!
The text was updated successfully, but these errors were encountered:
Hey, this is a bug with JoinVertical and JoinHorizontal in Lip Gloss. We're working on a new version that should fix this. Thank you for bringing it to our attention though, I was only able to reproduce this in a very specific situation before, so this gives us more to work with and room for improving our test coverage. Thank you!!
bubbles/help/help.go
Lines 197 to 201 in a9344b5
In the FullHelpView function, the spaces within the columns created by lipgloss.JoinHorizontal do not have dedicated style options. This results in inconsistent styling, especially when a background color is applied to the terminal. As shown in the attached screenshot, the spaces remain unstyled with no ability to apply custom styles, leading to visual discrepancies.
This issue is similar to the one described in issue #571, where the ShortHelpView function lacks style options for spaces between the key and description.
Screenshot:
To resolve this issue, I suggest wrapping the JoinHorizontal call in a Render call of the FullSeparator style. This would allow the other styles to override anything not set by the FullSeparator style, effectively styling the whitespace.
If you settle on an approach, I'm happy to implement it and provide a PR. Thanks again!
The text was updated successfully, but these errors were encountered: