I think this is done... There are some outstanding PRs on lipgloss with bugs found during the process. You can test it out interactively in this Bubble Tea PR. Do not commit the changes to go.mod or go.sum, they are needed for validation, but won't be necessary when the changes to Lip Gloss are merged.

PRs on lipgloss
charmbracelet/lipgloss#377
charmbracelet/lipgloss#373
charmbracelet/lipgloss#372

Some great next steps would be to test these changes against existing table issues to see if they persist now that we've delegated the rendering to lipgloss

Probably still needs a bit of a tidy too to make sure I haven't left a whole bunch of TODOs in there 😅 Will mark it ready for review once that's done

Okay, this is nearly ready for review. I did find another bug with text alignment that should be addressed before merging (on the test-issues-with-lg-table branch that will have tests from reported table issues). I haven't pushed it to remote yet as I'll debug that locally.

There are also some TODOs I've kept in here for the code review so it's clear where I might be feeling uncertain.

Edit: the alignment issue is only happening with bubbles, not with my lipgloss branch or master (lipgloss)... Weird thing is the truncation is all happening on the lipgloss side, so still need to figure that out 🤔

Right truncation from bubbles table (margins)

The issue above happens when the cell styles have margins. When you remove margins from the styling, it doesn't happen anymore. This shows that it's likely that the bubbles table is passing these styles along to the lipgloss table, but the rendered result is being truncated on the right rather than taking the alignment into account.

Weird truncation behaviour when table width is fixed

	t.Run("right-aligned text with fixed width table", func(t *testing.T) {
		s := DefaultStyles()
		s.Selected = s.Selected.Align(lipgloss.Right)
		s.Cell = s.Cell.Align(lipgloss.Right)
		biscuits := New(
			WithColumns([]Column{
				{Title: "Name", Width: 25},
				{Title: "Country of Origin", Width: 16},
				{Title: "Dunk-able", Width: 12},
			}),
			WithRows([]Row{
				{"Chocolate Digestives", "UK", "Yes"},
				{"Tim Tams", "Australia", "No"},
				{"Hobnobs", "UK", "Yes"},
			}),
			WithStyles(s),
		)
		biscuits.SetWidth(30)
		t.Logf("\n%s", ansi.Strip(biscuits.View()))
	})

In this case, the Cell style doesn't have margins set anymore.

I'm able to reproduce the row truncation issue in lipgloss' table when I set a margin, so will work on fixing that outside of this PR, then hopefully this should be good to go