Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cgroup): add editor for cgroup.conf file #19

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

NucciTheBoss
Copy link
Member

Adds an editor for the cgroup.conf configuration file. This editor is required to make the slurm_ops charm library in hpc-libs capable of the managing the cgroup.conf configuration on slurmctld machines.

Related discussion from way back yonder: https://github.com/orgs/charmed-hpc/discussions/8

It's a pretty simple editor 😄

@NucciTheBoss NucciTheBoss added the Type: Enhancement Proposes a new feature to be added to the project. label Sep 18, 2024
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Loving that we're centralizing all the config logic on a single place.

@NucciTheBoss NucciTheBoss merged commit 6d49ea8 into charmed-hpc:main Sep 19, 2024
3 checks passed
@NucciTheBoss NucciTheBoss deleted the feat-cgroup branch October 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Proposes a new feature to be added to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants