feat(editors): enable editors to set file access permissions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the function `set_file_permissions` which is used by the dump function of the editors to apply file mode, user, and group permissions to supported configuration files. This makes Slurm happy because then we don't need to default to root for everything, and can instead use the dedicated SlurmUser. Signed-off-by: Jason C. Nucciarone <[email protected]>
Also improves coverage of the `editor` module. Signed-off-by: Jason C. Nucciarone <[email protected]>
Use `pyfakefs` to create a mock Slurm configuration file where we would expect it to be located on a node. Also helps for testing file permissions as we don't need to mess with privileges on the host filesystem. Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
added
the
Type: Enhancement
jedel1043
reviewed
Oct 7, 2024
|
@jedel1043 please sir, might I have another review 🥺👉👈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the capabilities of the
dumpandeditfunctions to set file mode, user, and group owner on Slurm configuration files. All the editors use the sharedset_file_permissionsfunction under the hood to perform the permissions modification. This functionality is needed to that we can ensure that configuration files are owned by the correctSlurmUserrather than them all being owned by root.Misc.
Swaps out the tempfile we were creating on disk for the unit tests and replaces it with
pyfakefs. This way we don't have to worry about manually cleaning up testing resources with the addition of each new unit test.