Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check PR reviews action is passing even without any reviewers assigned in some cases #72

Open
ramaghanta opened this issue Mar 14, 2024 · 0 comments

Comments

@ramaghanta
Copy link

Check PR reviews action is passing even without any reviewers assigned. Generally, this action doesn't run until someone comments on the PR. But because @carlansley, commented on the PR, the action ran and reported that the action passed.

image

I suspect the issue is https://github.com/checkdigit/github-actions/blob/main/src/check-pr-reviews/index.ts#L15. the condition should probably be >= 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant