Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rule to make every header should be explicit in defining whether it is required #20

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Added rule to make every header should be explicit in defining whether it is required #20

merged 1 commit into from
Nov 25, 2024

Conversation

jpolavar
Copy link
Contributor

Closes #15

@jpolavar jpolavar added the PATCH label Nov 21, 2024
@jpolavar jpolavar self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

Beta Published - Install Command: npm install @checkdigit/[email protected]

@jpolavar jpolavar requested a review from lukebrdn November 21, 2024 20:00
lukebrdn
lukebrdn approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@lukebrdn lukebrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

✅ PR review status - All reviews completed and approved!

@jpolavar jpolavar merged commit 6c788b8 into main Nov 25, 2024
8 checks passed
@jpolavar jpolavar deleted the required-property-headers branch November 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebrdn lukebrdn lukebrdn approved these changes

Assignees

@jpolavar jpolavar

Labels
PATCH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create custom rule (if one doesn't exist) to require required property for all headers
2 participants
@jpolavar @lukebrdn