-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: allow to run criu under strace #2273
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2273 +/- ##
============================================
- Coverage 70.55% 70.53% -0.03%
============================================
Files 132 135 +3
Lines 33511 33526 +15
============================================
+ Hits 23643 23646 +3
- Misses 9868 9880 +12
☔ View full report in Codecov by Sentry. |
fork_and_ptrace_attach has to fork a child with CLONE_UNTRACED, so that strace doesn't trace it. Signed-off-by: Andrei Vagin <[email protected]>
LGTM, but I was not able to replicate the problem in #2269 (comment). |
@avagin Thanks! I was able to reproduce the problem and confirm that the patch works. |
fork_and_ptrace_attach has to fork a child with CLONE_UNTRACED, so that strace doesn't trace it.