Support criu-image-streamer through RPC #2533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programs calling CRIU through RPC may want access to image streaming for faster data transfer. To use image streaming through RPC, (1) criu-image-streamer must be started by the calling program. (2) The RPC call must enable stream in `criu_opts`. Signed-off-by: Liana Koleva <[email protected]>
lianakoleva
force-pushed
the
rpc_support_img_streamer
branch
from
147a50b to
0f05b59
Compare
rst0git
reviewed
Dec 3, 2024
| @@ -905,7 +901,7 @@ static int check(int sk, CriuOpts *req) | |||
| __setproctitle("check --rpc"); | |||
|
|
|||
| opts.mode = CR_CHECK; | |||
| if (setup_opts_from_req(sk, req)) | |||
| if (setup_opts_from_req(sk, req, -1)) | |||
There was a problem hiding this comment.
Would it be possible to add a comment that explains why we use -1 here?
rst0git
reviewed
Dec 3, 2024
| @@ -1015,7 +1011,7 @@ static int start_page_server_req(int sk, CriuOpts *req, bool daemon_mode) | |||
| close(start_pipe[0]); | |||
|
|
|||
| opts.mode = CR_PAGE_SERVER; | |||
| if (setup_opts_from_req(sk, req)) | |||
| if (setup_opts_from_req(sk, req, -1)) | |||
There was a problem hiding this comment.
It would be good to add a similar comment here.
rst0git
reviewed
Dec 3, 2024
|
@lianakoleva Would it be possible to run tests for this functionality with ZDTM? For example, something similar to |
Parameter `int mode` conflicts with another variable in this function. Signed-off-by: Liana Koleva <[email protected]>
The `image_dir_mode` function was modified to base output on opts.mode only. This required changes to accommodate for CR_CPUINFO, which has a subcommand. Signed-off-by: Liana Koleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs calling CRIU through RPC may want access to image streaming
for faster data transfer.
To use image streaming through RPC,
(1) criu-image-streamer must be started by the calling program.
(2) The RPC call must enable stream in
criu_opts.